Skip to content
Snippets Groups Projects
This project is mirrored from https://projects.blender.org/blender/blender. Pull mirroring updated .
  1. Apr 15, 2024
  2. Apr 10, 2024
  3. Mar 22, 2024
  4. Mar 21, 2024
  5. Mar 19, 2024
  6. Mar 18, 2024
  7. Mar 14, 2024
    • Bastien Montagne's avatar
      Fix LibOverride asserting when same RNA path changes type. · 2c4589ca
      Bastien Montagne authored
      Although rare (and not recommended!), it can happen that a same exact
      RNA path points to a different type of data.
      
      This can come from an update of the code itself, but this is very
      unlikely and discouraged.
      
      However, geometry nodes and their 'modifiers' interface have made it way
      more easy to create such conflicting situation, since users are free to
      re-arrange and edit the nodes and their 'public' interface as they
      want...
      
      Found out while investigating some unrelated issues in some studio Gold
      production files (namely,
      `pro/shots/090_joining_whale/090_0130/090_0130-anim.blend` r2110
      exhibits such issue for `OBGEO-mika-body`
      `modifiers["RIG-GN-mask-clothing"]["Socket_3"]`, where the RNA type
      changes from integer to bool).
      
      NOTE: Cherry-pick of 6adf5adb, had to do some non-trivial changes to
      get it to work in older code though.
      
      Pull Request: https://projects.blender.org/blender/blender/pulls/119429
      2c4589ca
  8. Mar 13, 2024
    • Bastien Montagne's avatar
      Fix #118300: Broken liboverride data can crash Blender on load. · cdb6e15b
      Bastien Montagne authored
      Second issue reported in the comment was caused by some shapekeys
      flagged as embedded liboverride data, when their owner ID (Mesh e.g.)
      is not a liboverride at all.
      
      The `BKE_lib_override_library_validate` called on file read was only
      covering real liboverride IDs, which where then supposed to take care of
      their own embedded data. But since the owner ID is already a full
      non-override ID, its embedded data ended up never being properly
      sanitized.
      
      Most likely more corruption data from quite old files and/or deprecated
      experimental features.
      cdb6e15b
    • Bastien Montagne's avatar
      Fix #118299: Crash in some cases with invalid/deprecated LibOverride data. · 94554354
      Bastien Montagne authored
      `BKE_lib_override_library_validate` used on fileread to ensure all
      liboverrides are valid was using direct call to
      `BKE_lib_override_library_free`. However, this was lacking the handling
      of embedded dependencies (from liboverride PoV), in particular
      ShapeKeys.
      
      Since these shapekeys were still tagged as embedded liboverrides,
      liboverride code would later assume their owner (mesh etc.) was also a
      valid liboverride, leading to various potential issues.
      
      Use instead `BKE_lib_override_library_make_local`, which also ensures
      that embedded dependencies are handled properly.
      94554354
    • Philipp Oeser's avatar
      Revert "Fix missing relations built for camera referenced by markers" · 5edbcb1a
      Philipp Oeser authored
      This reverts commit 93f8b591.
      
      Having it without b2482955 backported as well [which has non-trivial conflicts] would cause harm
      5edbcb1a
  9. Mar 12, 2024
  10. Mar 11, 2024
Loading