Skip to content
Snippets Groups Projects
Unverified Commit 9a49e00e authored by Rebecca Taft's avatar Rebecca Taft Committed by GitHub
Browse files

Merge pull request #117631 from rytaft/backport23.1.14-rc-111347


release-23.1.14-rc: sql: fix an exported gist out of bounds error (#117631)

Co-Authored-By: default avatarTommy Reilly <treilly@cockroachlabs.com>
parents ec0a6385 c17b2639
No related branches found
No related tags found
No related merge requests found
......@@ -258,7 +258,9 @@ func groupByColumns(
columns := make(colinfo.ResultColumns, 0, len(groupCols)+len(aggregations))
if inputCols != nil {
for _, col := range groupCols {
columns = append(columns, inputCols[col])
if len(inputCols) > int(col) {
columns = append(columns, inputCols[col])
}
}
}
for _, agg := range aggregations {
......
......@@ -1122,3 +1122,33 @@ explain(shape):
syntax: "select 123"
explain(gist):
• show completions
# Regression for #111346
explain-plan-gist
AgFWBgCPAQIAABNWCgsGBwwHHA0UAXoCBgEFUCJ6AQ==
----
• upsert
│ into: ?()
│ auto commit
└── • lookup join (left outer)
│ table: ?@?
│ equality: (_, _, _) = (?,?,?)
│ equality cols are key
└── • distinct
│ distinct on
└── • render
└── • render
└── • group (hash)
│ group by: _, _, _
└── • index join
│ table: ?@?
└── • scan
table: ?@?
spans: 1 span
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment