This project is mirrored from https://github.com/coder/coder.
Pull mirroring updated .
- Nov 17, 2023
-
-
Ben Potter authored
-
Steven Masley authored
Was returning a custom rego canceled error. This conforms with how Authorize handles this error.
-
Kayla Washburn authored
-
Steven Masley authored
* chore: add uuid to ssh connection logs
-
Cian Johnston authored
Adds a button on DeploymentHealth page to immediately re-run the healthcheck. Co-authored-by: BrunoQuaresma <bruno_nonato_quaresma@hotmail.com>
-
-
Bruno Quaresma authored
-
Bruno Quaresma authored
Before: <img width="483" alt="Screenshot 2023-11-17 at 11 29 25" src="https://github.com/coder/coder/assets/3165839/28e07832-d816-48d3-a3d5-500227f2799e"> After: <img width="491" alt="Screenshot 2023-11-17 at 11 29 30" src="https://github.com/coder/coder/assets/3165839/e01bc181-34af-4299-b86a-9081a5efd954">
-
Marcin Tojek authored
-
Bruno Quaresma authored
-
Bruno Quaresma authored
-
Spike Curtis authored
> Can someone help me understand the differences between these env variables: > > CODER_REDIRECT_TO_ACCESS_URL > CODER_TLS_REDIRECT_HTTP_TO_HTTPS > CODER_TLS_REDIRECT_HTTP Oh man, what a mess. It looks like `CODER_TLS_REDIRECT_HTTP ` appears in our config docs. Maybe that was the initial name for the environment variable? At some point, both the flag and the environment variable were `--tls-redirect-http-to-https` and `CODER_TLS_REDIRECT_HTTP_TO_HTTPS`. `CODER_TLS_REDIRECT_HTTP` did nothing. However, then we introduced `CODER_REDIRECT_TO_ACCESS_URL`, we put in some deprecation code that was maybe fat-fingered such that we accept the environment variable `CODER_TLS_REDIRECT_HTTP` but the flag `--tls-redirect-http-to-https`. Our docs still refer to `CODER_TLS_REDIRECT_HTTP` at https://coder.com/docs/v2/latest/admin/configure#address So, I think what we gotta do is still accept `CODER_TLS_REDIRECT_HTTP` since it was working and in an example doc, but also fix the deprecation code to accept `CODER_TLS_REDIRECT_HTTP_TO_HTTPS` environment variable.
-
Marcin Tojek authored
-
Spike Curtis authored
Re-enables TestSSH/RemoteForward_Unix_Signal and addresses the underlying race: we were not closing the remote forward on context expiry, only the session and connection. However, there is still a more fundamental issue in that we don't have the ability to ensure that TCP sessions are properly terminated before tearing down the Tailnet conn. This is due to the assumption in the sockets API, that the underlying IP interface is long lived compared with the TCP socket, and thus closing a socket returns immediately and does not wait for the TCP termination handshake --- that is handled async in the tcpip stack. However, this assumption does not hold for us and tailnet, since on shutdown, we also tear down the tailnet connection, and this can race with the TCP termination. Closing the remote forward explicitly should prevent forward state from accumulating, since the Close() function waits for a reply from the remote SSH server. I've also attempted to workaround the TCP/tailnet issue for `--stdio` by using `CloseWrite()` instead of `Close()`. By closing the write side of the connection, half-close the TCP connection, and the server detects this and closes the other direction, which then triggers our read loop to exit only after the server has had a chance to process the close. TODO in a stacked PR is to implement this logic for `vscodessh` as well.
-
- Nov 16, 2023
-
-
Bruno Quaresma authored
-
Bruno Quaresma authored
-
Kayla Washburn authored
-
Bruno Quaresma authored
-
Kira Pilot authored
-
Marcin Tojek authored
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/3.0.0...3.1.0 ) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Bruno Quaresma authored
-
Mathias Fredriksson authored
Fixes #10550
-
Dean Sheather authored
-
Dean Sheather authored
-
- Nov 15, 2023
-
-
Jon Ayers authored
-
Kayla Washburn authored
-
Cian Johnston authored
-
Kira Pilot authored
* feat: allow autostop to be specified in minutes and seconds * fix test
-
Cian Johnston authored
-
Steven Masley authored
Marked as a breaking change as the previous activity bump was always the TTL duration of the workspace/template. This change is more cost conservative, only bumping by 1 hour for workspace activity. To accommodate wrap around, eg bumping a workspace into the next autostart, the deadline is bumped by the TTL if the workspace crosses the autostart threshold. This is a niche case that is likely caused by an idle terminal making a workspace survive through a night. The next morning, the workspace will get activity bumped the default TTL on the autostart, being similar to as if the workspace was autostarted again. In practice, a good way to avoid this is to set a max_deadline of <24hrs to avoid wrap around entirely.
-
Cian Johnston authored
* Adds an annotation format_duration_ns to all deployment values of type clibase.Duration * Adds a unit test that complains if you forget to add the above annotation to a clibase.Duration * Modifies optionValue() to check for the presence of format_duration_ns when displaying an option.
-
Spike Curtis authored
-
Spike Curtis authored
re #10528 Adds SQL queries to support Tailnet v2 API in the PG Coordinator
-
- Nov 14, 2023
-
-
dependabot[bot] authored
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
dependabot[bot] authored
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Ben Potter authored
-