This project is mirrored from https://github.com/dart-lang/sdk.
Pull mirroring updated .
- Oct 08, 2024
- Oct 07, 2024
-
-
Nicholas Shahan authored
This is a step towards organizing the code from shared_command.dart and eventually deleting it. - Move `CompilerResult` from shared_command.dart. Change-Id: Ibe4b8bbd5c6deb2558392255f3818773fa4ea80e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388049 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com>
-
Ryan Macnak authored
Compared to (Chromium's) third_party/binary_size, this tool better simplifies paths and can handle `dart:` and `package:` "paths". Cf. e32d98cd. Change-Id: I9e757d9ba8422024584586899481279f7fd6542d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/387840 Reviewed-by: Brian Quinlan <bquinlan@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
-
Ryan Macnak authored
TEST=ci Change-Id: I840fc1a614186e0f330f4b2313a6706452af6998 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388665 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
-
Ryan Macnak authored
Implement type checks for leaf IL instructions using the instruction tag instead of per-type virtual functions, which scale quadratically with the number of IL instructions. out/ReleaseX64/exe.stripped/gen_snapshot 7601248 -> 6890640 (-9.3%) TEST=ci Change-Id: I3d9c84c67e6ab0f3020ebb02068451e6f1c150f7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388043 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
-
Keerti Parthasarathy authored
Change-Id: If81e7081207960b3a55bc6d6dc0b5488b50e35a5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388680 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Keerti Parthasarathy <keertip@google.com>
-
Parker Lougheed authored
Also adjusts the lint implementation to avoid a few nullable types and non-null assertions. Change-Id: I4199b8ebe94842613c7d8fb322c109c28f194f21 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388500 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Auto-Submit: Parker Lougheed <parlough@gmail.com>
-
Konstantin Shcheglov authored
Missed it in the previous CL. Change-Id: Ib887b8423ead76907c7302036a3d2089ba85dbfb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388720 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Nicholas Shahan authored
This is a step towards organizing the code from shared_command.dart and eventually deleting it. - Move `SharedCompilerOptions` and rename to `Options` from shared_command.dart along with helpers. Change-Id: Ic9edfb47fc2425a28b1e948d94fad96a2f594108 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388048 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Mark Zhou <markzipan@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
-
Konstantin Shcheglov authored
Change-Id: I85a24d0f1d0b4251415644fe1438503e41710436 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388682 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Nicholas Shahan authored
This is a step towards organizing the code from shared_command.dart and eventually deleting it. - Move `ParsedArguments` and helpers from shared_command.dart. Change-Id: I10a05f9595e5421b6d5498e2fd1138d0acfd5e35 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388047 Reviewed-by: Mark Zhou <markzipan@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
-
Mayank Patke authored
Change-Id: I9a8e519e2e85e670de610d3dd2001d153341789a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388663 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Mayank Patke <fishythefish@google.com>
-
Konstantin Shcheglov authored
Change-Id: Ie6cef4384699d8b5ca8b6877d6cfe7881d554d44 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388662 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com>
-
Sam Rawlins authored
* avoid_returning_null_for_void * await_only_futures Change-Id: Ic5665a7928cca64ec3e33c54c995ccbb67e954b2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388640 Auto-Submit: Samuel Rawlins <srawlins@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
-
Konstantin Shcheglov authored
Change-Id: Ib07ccd03b60a53814d2bc1a00716ffdfaa4dd698 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388661 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com>
-
Sam Rawlins authored
Fixes https://github.com/dart-lang/sdk/issues/56269 Change-Id: I025966fd4aa3d7c5b71175321f21f95e8c41f086 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388580 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Kevin Moore authored
Change-Id: I19b05ffc6bd8e87e58990a62a21b8a2986fe9f54 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382760 Commit-Queue: Nate Biggs <natebiggs@google.com> Auto-Submit: Kevin Moore <kevmoo@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I172356e3db5d2f145e6e91596de018018ea57f1f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388583 Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
FMorschel authored
R=paulberry@google.com Fixes https://github.com/dart-lang/sdk/issues/56844 Change-Id: Idb5c9420ecd9fda1d961c7211758721c4c4c7522 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388660 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
-
Danny Tuppeny authored
The `AnalysisDriverScheduler` already keeps timings of all of its operations (in `accumulatedPerformance`), but they're not easily accessible to users and might help track down some kinds of performance issues. This adds a new page to the diagnostics server that shows the timings, as well as a reset button to clear them so they can collect numbers just for a specific operation(s). It involves some tweaks to the server to handle `POST` (because we shouldn't really use `GET` to mutate anything). Change-Id: Ia49d471aaa1637a0c978f75569556b26982367d8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388561 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
-
Konstantin Shcheglov authored
Change-Id: I52c6a6eb31ba8b01a3b1c0bdb1b545346bb7d8ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388581 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Parker Lougheed authored
Change-Id: I68cd94dd9fb123d6a36a78d40c475f20c165a716 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388445 Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
-
Konstantin Shcheglov authored
Change-Id: I272de045d5e8d3287c568c108cf559955d32a091 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388243 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: Ifcbf62a09b8b77ecde4d5a16738faf5f0b8e1832 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388480 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: Id13597e0e0bc09f9486b663b0f3337fa6314867a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388070 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Auto-Submit: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Lasse Nielsen authored
Was `Future<Null>` even though it was returned as `Future<void>`, making `.timeout` fail due to contravariance when its callbacks is a `void`-function. Fixes #56846 CoreLibraryReviewExempt: Trivial change with no platform specific behavior. Change-Id: I80c93c16efbb1f3d5219922dc1f30db039c88364 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388400 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
-
Martin Kustermann authored
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try Change-Id: I08f3d07571f1f9733cb177be326ec99acc5d68ae Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388540 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
-
Sigurd Meldgaard authored
Changes: ``` > git log --format="%C(auto) %h %s" a7fbdb2..1efd3f5 https://dart.googlesource.com/pub.git/+/1efd3f5e Allow overriding `resolution` and `workspace` fields in pubspec_overrides. (4400) ``` Diff: https://dart.googlesource.com/pub.git/+/a7fbdb263d463640b5a7c1317c7f0ef51e1fb8ea..1efd3f5e274e153637d99698b0ee454f6f2550ab/ Change-Id: I913d44e1a3a4f2a183fff5ef1c3d85710306c719 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388620 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jake Macdonald <jakemac@google.com> Auto-Submit: Sigurd Meldgaard <sigurdm@google.com>
-
Sigurd Meldgaard authored
Changes: ``` > git log --format="%C(auto) %h %s" 9adca58..a7fbdb2 https://dart.googlesource.com/pub.git/+/a7fbdb26 Follow up to `--unlock-transitive` (4405) https://dart.googlesource.com/pub.git/+/a2026faf Rename flag to --unlock-transitive https://dart.googlesource.com/pub.git/+/db8f497c Add flag `--transitive` to `pub upgrade` https://dart.googlesource.com/pub.git/+/bcafc167 Hint about sdk constraint update for workspace and resolution (4384) https://dart.googlesource.com/pub.git/+/7113e53c Bump actions/checkout from 4.1.7 to 4.2.0 in the github-actions group (4401) https://dart.googlesource.com/pub.git/+/f4023f47 Do weekly dependabot checks (4399) ``` Diff: https://dart.googlesource.com/pub.git/+/9adca58e4fa8e1d94924e64a184532231826496c..a7fbdb263d463640b5a7c1317c7f0ef51e1fb8ea/ Change-Id: I0b49f54e1bb5c2266caf0934d19f35ace860438f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388560 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
-
Vyacheslav "Slava" Egorov authored
`Console.cursorPosition` can return null when you are typing too fast because it is implemented by sending an escape code to the terminal and reading what it responds. This response is naturally intermingled with normal input and the implementation does nothing to guard against that. We do not really need to know the cursor position though we are simply interested in keeping cursor on the same row. But this can be achieved by sending _horizontal position absolute_ which only changes column rather than _cursor position_ which sets both row and column. R=kustermann@google.com TEST=manually tested Change-Id: Ie1a064e37b90bc4529ac4f5c1259642ad5680ca6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388340 Commit-Queue: Slava Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
-
Chloe Stefantsova authored
Part of https://github.com/dart-lang/sdk/issues/55954 Change-Id: Ie22ff9ddf50f47e20b1cfbf11f01bdc900123619 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388003 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
-
- Oct 05, 2024
-
-
Konstantin Shcheglov authored
Change-Id: I8742dc8cf82c7144e501afbbf0755651f414b00f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388072 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
- Oct 04, 2024
-
-
Nicholas Shahan authored
This is a followup to https://dart-review.googlesource.com/c/sdk/+/386900. Since manually sharding the co19 tests on the firefox configuration by subdirectories there have been no infrastructure failures on the ddc-linux-firefox bot. This change reduces the number of shards per each subdirectory shard as an experiment to see if this will cause one of them to start causing failures. Change-Id: I1d8e0440134ade0c4c0be91e7ad8278b7bcacb01 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388068 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I2aa046737b780c7fa166d985c694a5ceb884ab58 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388069 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Auto-Submit: Phil Quitslund <pquitslund@google.com>
-
Sam Rawlins authored
Fixes https://github.com/dart-lang/sdk/issues/56328 Change-Id: I144d9ca92a93bcc72c2cdd2016fcb2784f2858ee Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388067 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
-