This project is mirrored from https://github.com/dart-lang/sdk.
Pull mirroring updated .
- Oct 31, 2024
-
-
Nate Biggs authored
Change-Id: I9fb5198dc460e5707f9185018018724fd2aac565 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392720 Commit-Queue: Nate Biggs <natebiggs@google.com> Auto-Submit: Nate Biggs <natebiggs@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
- Oct 30, 2024
-
-
Sam Rawlins authored
Fixes https://github.com/dart-lang/sdk/issues/47256 See specified behavior at https://github.com/dart-lang/sdk/issues/47256#issuecomment-2374880529 Additionally: * Make AnalysisOptionsProvider.sourceFactory private and final, which allows for promotion, yay! Change-Id: I26e0e73c661d48189078be95ff544fe8dfb7a86d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392100 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Nicholas Shahan authored
Ignore violations in the js_ast sub-directory to avoid unnecessary diffs with the original package. Change-Id: Iac8c942e5e2446b8433e2073b546c28e42a8f5cf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392700 Reviewed-by: Kevin Moore <kevmoo@google.com> Commit-Queue: Nicholas Shahan <nshahan@google.com>
-
Danny Tuppeny authored
Fixes https://github.com/dart-lang/sdk/issues/56994 Change-Id: I0721603b7b019ab09614265e412d3b9e76d26ad9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392660 Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
-
FMorschel authored
Fixes https://github.com/dart-lang/sdk/issues/56924 Change-Id: Ib697e7b29671331f4e5b87a2472e3be60f89ffa1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391021 Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Alexander Markov authored
All inputs of IL instructions are now non-speculative, SelectRepresentations pass now always inserts non-speculative unboxing instructions. In call specializer, where JIT compiler speculates, speculative Unbox instructions are now explicitly added for inputs which may have incorrect type. Unbox instructions now have 'value_mode' (either kHasValidType or kCheckType) instead of speculative mode. Added canonicalization rule to change value mode if compiler can prove that value has correct type. Also, cleaned up speculations around UnboxedInt32 representation in JIT mode, which aligns this representation with other unboxed representations. TEST=ci Change-Id: I52f5c959c3f6515b1a7c9e8ab15b420beed0e3f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391492 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Slava Egorov <vegorov@google.com>
-
Danny Tuppeny authored
Fixes https://github.com/dart-lang/sdk/issues/56794 Change-Id: Ied408503d22c4abb2c4f996f6c9b7847b8ad82be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389960 Reviewed-by: Derek Xu <derekx@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
-
Alex Wallen authored
Closes https://github.com/dart-lang/sdk/pull/56988 GitOrigin-RevId: da1fceb6e01622ca3bc63ede831c983d77c2417e Change-Id: I1bed7fcdfdbf891f3205fb7ffd3e104fa6528cc8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392406 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Sam Rawlins authored
Since the LintRule class is the basis for writing both "lint rules" (rules that must be explicitly enabled) and "warning rules" (rules that are enabled by default), it is a misnomer to use 'LintRule' as a supertype. This change adds an alias, 'AnalysisRule'. Additionally: * Rename LinterVisitor to AnalysisRuleVisitor. * Rename lintRuleTimers to AnalysisRuleTimers. * Rename LinterExceptionHandler to AnalysisRuleExceptionHandler. * Rename LintRuleExceptionHandler to _AnalysisRuleExceptionHandler. * NodeLintRegistry is used in too many places, so I have left it for now. Change-Id: I43340cca0f9b64502960d8f5e05c6c9b81c3dfd9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392203 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Konstantin Shcheglov authored
We now write and read library fragments in the correct order, so declarations are always read before augmentations. Change-Id: I5a35cf8d963c3a5010344361289d3be4dc5b7f11 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392620 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
FMorschel authored
R=pquitslund@google.com Fixes https://github.com/dart-lang/sdk/issues/56648 Change-Id: I34a697d914e3a480105a4388d77178a96425893a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390622 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com> Reviewed-by: Phil Quitslund <pquitslund@google.com>
-
Sam Rawlins authored
A follow-up from Konstantin's comments here: https://dart-review.googlesource.com/c/sdk/+/392501 Change-Id: I19853831d304c2ea3267969e99249ff356aad3ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392600 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
-
Sam Rawlins authored
This reverts commit b3f31a04. Reason for revert: Customer tests are now disabled. Original change's description: > Revert "Reapply "analyzer: separate unused_element_parameter from unused_element"" > > This reverts commit b551690c. > > Reason for revert: flutter customer tests failing: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738601049545714785/+/u/run_test.dart_for_customer_testing_shard_and_subshard_None/stdout > > Original change's description: > > Reapply "analyzer: separate unused_element_parameter from unused_element" > > > > Fixes #49025. Fixes #48401 > > > > This allows users to blanket ignore unused_element_parameter without > > ignoring unused_element. They are reported in distinct situations so it > > is valid to separate them. > > > > This reverts commit b888da75. > > > > Change-Id: I8ea52fcdcb491c140c1283602d6911c939e78d50 > > Tested: trybots > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381882 > > Reviewed-by: Ben Konyi <bkonyi@google.com> > > Commit-Queue: Samuel Rawlins <srawlins@google.com> > > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> > > Change-Id: Ie0df2f4be45e5db2fa255dcf8c30ddf8408c155b > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382420 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Matan Lurey <matanl@google.com> > Commit-Queue: Samuel Rawlins <srawlins@google.com> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> > Reviewed-by: Ryan Macnak <rmacnak@google.com> Change-Id: Icbe69690e83daecc5a0649d2f632ffc33ba6394c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386722 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Matan Lurey <matanl@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
-
Ryan Macnak authored
Shifting the interesting bit to the sign bit is shorter than loading a large immediate. TEST=ci Change-Id: Ibd3dadf3885b554643e4606e8cbf83fcc6ba3d30 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392463 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Aprelev <aam@google.com>
-
Ryan Macnak authored
dart2js.aot.rv64gc 28061800 -> 27559904 (-1.8%) dart2js.aot.rv64gcb 27996112 -> 27510728 (-1.7%) TEST=ci Bug: https://github.com/dart-lang/sdk/issues/54955 Change-Id: Ic18ab8c33f59c36561fa7e7aed4d06f4e8f8c9dc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357215 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
-
Sam Rawlins authored
There are fewer than 140 `comment_references` violations after this change. Change-Id: I1d19db7e293b43400a6e076945d84f509862f873 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392501 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Sam Rawlins authored
Change-Id: Ib9c992d480b5c20cb90fabb0ebe90cbab2af4a12 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392407 Auto-Submit: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
FMorschel authored
R=scheglov@google.com Fixes https://github.com/dart-lang/sdk/issues/54786 Change-Id: I1354e3cde559229d5167a27e51efb6d030e5f8bc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392400 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Alexander Markov authored
Inferring array element type E from static type Iterable<E> allows compiler to remove extra checks left from iterator code. This is valid as List<E> implements Iterable<E>. This change makes for-in loops over built-in lists with static types Iterable<E> as efficient as loops over List<E>. TEST=runtime/tests/vm/dart/regress_56840_il_test.dart Fixes https://github.com/dart-lang/sdk/issues/56840 Change-Id: Ie52208b9c3e92dcc52079e66c910b023f09a2173 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392401 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
-
Danny Tuppeny authored
This removes `_addIdentifierRegion_dynamicLocal` and just inlines the region kind into the existing variable/name methods, that way the modifiers are still applied without having to duplicate them in `_addIdentifierRegion_dynamicLocal`. Fixes https://github.com/Dart-Code/Dart-Code/issues/5324 Change-Id: I7f39ec828c916de0fb99d8c71baa78a2f690c94b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392582 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Danny Tuppeny authored
Fixes https://github.com/dart-lang/sdk/issues/56981 Change-Id: I817625962b5a4975ec5f597ab147fe7312cdf06f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392580 Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Danny Tuppeny authored
Change-Id: I72d5c9f841d9f85b7f9597a309b14ba4b7e0d3a8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391800 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
-
Johnni Winther authored
This combines the information about a constructor name needed to refer to its simple and full name and the corresponding offsets into a single class which is then used on fragments. Change-Id: Ibed0456c4517d15fde59f591a05286c5dd2b3204 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392423 Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
-
- Oct 29, 2024
-
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I5daf74b41840326d4928e15861cb4c80fac79f55 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392405 Auto-Submit: Phil Quitslund <pquitslund@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I587895b2115cd9e6da0c566a115438e1c506669b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392481 Auto-Submit: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
-
Phil Quitslund authored
Bug: https://github.com/dart-lang/linter/issues/5099 Change-Id: I20f3cf3febb5a89e6c39e4b6400cde4ccf28e982 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392468 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Auto-Submit: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
-
Liam Appelbe authored
I haven't been able to get a solid repro the tsan flake locally, and I'm not sure how to write a test for it, but this change is pretty uncontroversial anyway, so I'm inclined to just land it and see what happens. I have some weak evidence that this fixes the issue though. Before this change I ran the flaky command about 500 times before I saw a failure (though I didn't get any useful data from the failure, and it didn't look quite the same as the bug). With the change, the command ran 3500 times before flaking. I'm not sure if it's the same flake though (rr isn't working for me atm). Bug: https://github.com/dart-lang/sdk/issues/56900 Fixes: https://github.com/dart-lang/sdk/issues/56900 Change-Id: I939e8ceca4051ec91e942ca38a2b01477b67ddd8 TEST=CI Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392162 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Liam Appelbe <liama@google.com>
-
Konstantin Shcheglov authored
Change-Id: Ied0120823ed8b20eb0dc72143435cf1e15907ed9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392480 Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Konstantin Shcheglov authored
Change-Id: Id6ebeaea49627de09207c96652c600116b71c5bf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392500 Reviewed-by: Phil Quitslund <pquitslund@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
-
Sam Rawlins authored
This corrects about 40 of 220 comment_references issues in the analyzer package. In correcting the `experimentStatusToStringList` function, I see that it is unused. Change-Id: I0c2ec602262121337e7305797596fac9df987973 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392243 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Sam Rawlins authored
Change-Id: I2a5aa6a17355249f8de9d013efc6adea4be7d949 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392320 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
-
Siva Annamalai authored
Added the option 'js-dev' to the compile command to allow compilation of Dart sources using DDC. This ensures that tools will not be reaching into the internal implementation details of a Dart SDK to run DDC. TEST=unit tests added in compile_test.dart Change-Id: I3c670b43a989dfa60c75622fdbc1b7f99b399293 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392202 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
-
Devon Carew authored
Change-Id: Ic060e250d5e6e481a37b23032da79d021496fec2 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392465 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
-