Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/dgraph-io/dgraph. Pull mirroring updated .
  1. Mar 07, 2023
  2. Mar 03, 2023
  3. Dec 21, 2022
  4. Dec 14, 2022
    • Joshua Goldstein's avatar
      chore(ci): set up ci for 21.03-slash (#8469) · 7dfac4ec
      Joshua Goldstein authored
      ## Problem
      
      Currently our CI runs against main. We would like to run CI against our
      slash branch also.
      
      ## Solution
      
      In order for CI to run on release/v21.03-slash we must bring over all
      the latest changes we made to our main branch. This is work going back a
      few months, hence the large number of changes. Going forward we should
      keep CI/CD related changes on release branches and main in harmony.
      
      ## Steps:
      ```
      git checkout release/v21.03-slash
      git checkout main -- Makefile
      git checkout main -- dgraph/Makefile
      git checkout main -- .github
      git checkout main -- .go-version
      git checkout main -- t
      git checkout main -- tlstest/mtls_internal/tls
      git checkout main -- graphql/e2e/custom_logic/cmd/Dockerfile
      git checkout main -- systest/ldbc
      git rm .github/workflows/{main.yml,golanglintci-lint.yml,label.yml}
      ```
      
      Bring in coverage changes from #8494 in testutil/{docker.go,bulk.go},
      bring in updated dockercompose files (with coverage variable), and
      coverage entrypoint
      
      ## Todo
      
      https://github.com/dgraph-io/dgraph/pull/8277
      7dfac4ec
  5. Oct 30, 2021
  6. Oct 26, 2021
  7. Oct 19, 2021
  8. Oct 18, 2021
    • Daniel Mai's avatar
      fix(sort): Only filter out nodes with positive offsets. (#8081) · f9add833
      Daniel Mai authored
      Cherry-picked from #8077
      
      Negative offsets (e.g., offset: -4) can cause panics when sorting. This can happen when the query has the following characteristics:
      
      1. The query is sorting on an indexed predicate
      2. The results include nodes that also don't have the sorted predicate
      3. A negative offset is used.
      
          (panic trace is from v20.11.2-rc1-23-gaf5030a5)
          panic: runtime error: slice bounds out of range [-4:]
          goroutine 1762633 [running]:
          github.com/dgraph-io/dgraph/worker.sortWithIndex(0x1fb12e0, 0xc00906a880, 0xc009068660, 0x0)
                  /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:330 +0x244d
          github.com/dgraph-io/dgraph/worker.processSort.func2(0x1fb12e0, 0xc00906a880, 0xc009068660, 0xc0090686c0)
                  /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:515 +0x3f
          created by github.com/dgraph-io/dgraph/worker.processSort
                  /ext-go/1/src/github.com/dgraph-io/dgraph/worker/sort.go:514 +0x52a
      f9add833
  9. Oct 05, 2021
  10. Sep 25, 2021
    • Naman Jain's avatar
      fix(probe): do not contend for lock in lazy load (#8037) (#8041) · 04ee0669
      Naman Jain authored
      Earlier the admin server mutex lock was used to protect the graphql schema map. But now we store that in schema store that internally handles the concurrency. Hence, we don't need to take the admin server's read lock to access schema.
      
      /probe/graphql is used as health check and is called very frequently. This rlock on adminserver mutex makes the /probe/graphql requests block while lazy loading when restore operation gets triggered at the startup. That leads to so many go routines being spun up.
      
      (cherry picked from commit 5ad40d84)
      04ee0669
  11. Sep 24, 2021
  12. Sep 03, 2021
  13. Aug 31, 2021
  14. Aug 24, 2021
  15. Aug 19, 2021
    • Naman Jain's avatar
      feat(acl): allow access to all the predicates using wildcard (#7991) (#7994) · f18b1556
      Naman Jain authored
      * fix(acl): subscribe for the correct predicates (#7992)
      
      We were subscribing to the wrong predicates. Hence the ACL cache was not getting updated.
      
      (cherry picked from commit 1b75c01d)
      
      * feat(acl): allow access to all the predicates using wildcard (#7991)
      
      There are usecases that need read/write/modify permissions over all the predicates of the namespace. It is quite tedious to manage the permissions every time a new predicate is created.
      This PR adds a feature to allow a group, access to all the predicates in the namespace using wildcard dgraph.all.
      
      This example provides to dev group, read+write access to all the predicates
      
      mutation {
        updateGroup(
          input: {
            filter: { name: { eq: "dev" } }
            set: { rules: [{ predicate: "dgraph.all", permission: 6 }] }
          }
        ) {
          group {
            name
            rules {
              permission
              predicate
            }
          }
        }
      }
      
      NOTE: The permission to a predicate for a group (say dev) is a union of permissions from dgraph.all and the permissions to specific predicate (say name). So suppose dgraph.all is given READ permission, while predicate name is given WRITE permission. Then the group will have both READ and WRITE permission.
      (cherry picked from commit 3504044d)
      f18b1556
  16. Aug 13, 2021
  17. Aug 12, 2021
    • Naman Jain's avatar
      fix(acl): filter out the results based on type (#7978) · 35538556
      Naman Jain authored
      We store the groupId and userId in a predicate named dgraph.xid.There was a subtle bug where if a we create the group with same name as that of a user, then the user is not able to log in. This happens because we were not applying a filter by type.
      
      This PR fixes that.
      35538556
  18. Aug 06, 2021
  19. Jul 29, 2021
  20. Jul 26, 2021
    • Ahsan Barkati's avatar
      fix(rollups): Write rolled-up keys at ts+1 (#7957) · e7970254
      Ahsan Barkati authored
      Write rolled up keys at (max ts of the deltas + 1) because if we write 
      the rolled-up keys at the same ts as that of the delta, then in case of
      WAL replay the rolled-up key would get over-written by the delta which
      can bring DB to an invalid state.
      e7970254
  21. Jul 16, 2021
  22. Jul 15, 2021
  23. Jul 14, 2021
  24. Jul 07, 2021
  25. Jul 02, 2021
  26. Jun 30, 2021
  27. Jun 28, 2021
  28. Jun 25, 2021
  29. Jun 24, 2021
    • Naman Jain's avatar
      fix(groot): do not upsert groot for all namespaces on restart (#7917) (#7924) · 0ab2352a
      Naman Jain authored
      Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed.
      The change was made in the PR #7759 to fix a bulk loader edge case.
      This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.
      
      (cherry picked from commit 6730f10b)
      0ab2352a
Loading