This project is mirrored from https://github.com/livekit/livekit.
Pull mirroring updated .
- Nov 05, 2021
-
-
David Zhao authored
-
- Nov 04, 2021
-
-
David Zhao authored
-
David Zhao authored
-
- Nov 03, 2021
-
-
David Colburn authored
-
- Nov 02, 2021
-
-
Mathew Kamkar authored
-
Mathew Kamkar authored
* room with logger * participant with room logger * transport with room logger * simplify room logger usage * simplify logger * update protocol * more room logging, test fix
-
- Nov 01, 2021
-
-
David Zhao authored
-
- Oct 31, 2021
-
-
David Zhao authored
* Fix faulty participant update buffering. * Fix bug with broadcasting out of order * dedicated participant update worker, without locks * use tracker to drop duplicate/out of date messages * additional lock around filter logic
-
- Oct 29, 2021
-
-
Mathew Kamkar authored
* room allocator interface * remove wire bind * fix test
-
David Zhao authored
-
- Oct 26, 2021
-
-
David Colburn authored
-
David Colburn authored
-
- Oct 25, 2021
-
-
Raja Subramanian authored
Got the following error on a fresh install ``` wire: /root/ws/livekit-server/pkg/service/interfaces.go:35:2: DeleteRoom redeclared wire: /root/ws/livekit-server/pkg/service/interfaces.go:38:2: other declaration of DeleteRoom wire: generate failed Error: exit status 1 ``` Probably something from the latest `wire` version. After consulting David, removing the duplicate. Testing: -------- - Server builds and runs. Client is able to connect.
-
- Oct 21, 2021
-
-
David Colburn authored
-
David Colburn authored
-
Raja Subramanian authored
* Prevent missing entry in pending tracks Problem: -------- A track received via signalling request `AddTrack` is stored in `pendingTracks` of participant. A MediaTrack is created when `onTrack` fires after `SetRemoteDescription`. At that time, pending tracks are searched to find a matching track and look up an already published MediaTrack. This is because `onTrack` fires once for every layer of Simulcast and MediaTrack abstraction is for a media track and not one for every layer of Simulcast track. To accomplish that, pending tracks are cleaned up 5 seconds after the MediaTrack is created. The theory there is that `onTrack` will fire on all layers within 5 seconds. But, have observed several instances on my slow machine of that firing after 5 seconds which results in the search failing and we end up creating a new MediaTrack. The above is probably the reason (I am guessing though) for subscriber PC having an extra m-line some times. Considered fix: --------------- One possible option is to increase that 5 seconds timeout to a very large value. But, it has another issue. `getPendingTrack` is given the track id which comes in the SDP. Entries are added to the pending tracks using track id received via the `AddTrack` signalling message. And those two need not be the same. Especially Firefox has different ids every time. Not sure if that is something we do on client side which causes that, but it does look like a real possibility. To handle that case, `getPendingTrack` looks up tracks by media kind (audio/video) if the look up by SDP client id fails. Here, it is possible that there are two pending tracks of type video (think camera and screen sharing as an example) and looking up by kind might end up picking the wrong one. Fix: ---- Store the signalled client id and SDP client id in the MediaTrack and look up the published tracks by SDP client id for a track match. If there is no match, create a new MediaTrack and add it to publishedTracks and delete the corresponding pending track all within the lock (yeah not great to have a lot of code within the lock, but this is probably worth it to have the correctness). This does solve the issue of deferred pending track removal causing issues. However, note that kind based look up may do some switching. In a scenario where there are two pending tracks of kind video and the look up has to rely on kind, it is possible that signalCid and sdpCid get cross matched (i. e. client might have sent a signalCid for a Simulcast track, but during kind based look up it gets assigned to a non-simulcast track). I think that is okay as there is no strong correlation between the two. Testing: -------- - Connect from Chrome, Firefox (both orders, Chrome joining first, Firefox joining first) and ensure that media subscriptions and publishing are correct - Ensure that DTX munging works properly too. * Fix tests Add back adding track to publishedTracks for testing purposes. * Add a test to check case of `AddTrack` rejecting already published track * Remove debug. * Address PR comments - do not need to return SDP cid from `getPendingTracks`.
-
- Oct 20, 2021
-
-
David Zhao authored
-
David Colburn authored
-
David Zhao authored
-
- Oct 19, 2021
-
-
Raja Subramanian authored
- Update ion-sfu to v1.20.14 - Enable `abs-send-time` for video tracks Reference: ion-sfu PR - https://github.com/livekit/ion-sfu/pull/12 Testing: -------- - Look at SDP offer in subscriber PC and ensure that abs-send-time is negotiated. - Ensure that downstream packets have `abs-send-time` extension for video packets. TODO: ----- - Not yet setting this for audio tracks. Eventually we want to move to TWCC. This is just a step along the way.
-
David Colburn authored
* small refactor * extra line * fix room allocator test * selector fakes not used * keep decisions out of router * put nodeId logic back * fix room allocator test
-
- Oct 18, 2021
-
-
David Colburn authored
* more generic turn server * public turn realm name * support turn cert itself in config * remove cert/key from config * double auth handler * generate Co-authored-by: Mathew Kamkar <578302+matkam@users.noreply.github.com>
-
- Oct 15, 2021
-
-
David Zhao authored
-
David Zhao authored
-
David Zhao authored
mixing of simulcast and non-simulcast tracks is broken
-
- Oct 14, 2021
-
-
David Zhao authored
* Support passing along Source attribute
-
Raja Subramanian authored
* WIP - Re-use transceiver * Support both old and new methods for adding transceiver
-
- Oct 13, 2021
-
-
Raja Subramanian authored
* LK-105 (Opus DTX) https://linear.app/livekit/issue/LK-105/allow-enabling-of-opus-dtx Enable/Disable Opus DTX using SDP answer based on setting in `AddTrack` request. Testing: -------- Chrome and Firefox work. Having audio problems with Safari (maybe the Safari 15 issue as I am not getting media) * Check that receiver has no tracks * Skip non-audio transceivers * A small clean up to not use pendin track outside lock and also append with spread * Address comments from review by David * Update pkg/rtc/participant.go Co-authored-by: David Zhao <david@davidzhao.com> * Pull in tagged version of webrtc and lk protocol Co-authored-by: David Zhao <david@davidzhao.com>
-
- Oct 12, 2021
-
-
Mathew Kamkar authored
* signal ws connection, participant join, ice connection * must register * offer negotiation * dz review: offer and offer_response * dz review: answer
-
- Oct 11, 2021
-
-
David Zhao authored
-
Artur Shellunts authored
* Fix "ineffectual assignment" linter warning * Simplify TestClientCouldConnect * Simplify range expression
-
David Zhao authored
-
Brint E. Kriebel authored
* cli: Allow setting the current node region with flag or env variable Also add region to "starting LiveKit server" log. * routing: Add region to node registration Register the node's region on the selected router so it can be used for region aware node selection. Also add the region to the list-nodes output. * regionaware: Set minDist to zero for the current node If you don't set the minDist when leaving the loop early for a node that matches the current region, the minDist value with still be at max. This causes the the wrong node to be selected if the current node is the first one the loop passes through. Add a test that validates this change. The new test fails if this new change is not in place.
-
cnderrauber authored
Co-authored-by: cnderrauber <zengjie9004@gmail.com>
-
- Oct 10, 2021
-
-
David Colburn authored
-
- Oct 09, 2021
-
-
David Zhao authored
-
- Oct 08, 2021
-
-
Mathew Kamkar authored
-
David Colburn authored
* update recording service * return empty for EndRecording * update protocol
-
- Oct 07, 2021
-
-
Russ d'Sa authored
* consolidate on api key and api secret to describe our key pairs * tweak error message for the keys flag
-
David Zhao authored
-