Skip to content
Snippets Groups Projects
Unverified Commit 51ff1b43 authored by Pascal Bihler's avatar Pascal Bihler Committed by GitHub
Browse files

fix: senderId removed in Electron 28 (#171)


* Accepting ipc events without senderId

Since the property has been removed with Electron 28

* Access senderId on cast event object to be compatible with Electron 28, where "senderId" is removed from IpcRendererEvent

* fix type error

* Implement interface for missing senderId check

* replace process.mainModule with a while loop to get the topmost parent

* disable test using removed APIs

* split the codepaths for electron 28 and electron < 28

* prefix comment for skipped test with TODO

* chore: formatting

---------

Co-authored-by: default avatarJeremy Rose <nornagon@nornagon.net>
Co-authored-by: default avatarKilian Valkhof <kilian@kilianvalkhof.com>
Co-authored-by: default avatarDavid Sanders <dsanders11@ucsbalum.com>
parent 642040db
No related branches found
Tags v2.1.1
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment