Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/getsentry/snuba. Pull mirroring updated .
  1. Jan 26, 2023
  2. Jan 25, 2023
  3. Jan 24, 2023
  4. Jan 23, 2023
  5. Jan 20, 2023
  6. Jan 19, 2023
  7. Jan 18, 2023
    • Dan Fuller's avatar
      chore(eventstream): Fix eventstream dev api to return 500s when there is an error (#3595) · f882dca5
      Dan Fuller authored
      When we have an error here (for example, due to a dataset not existing) we end up with an obscure
      connection error in sentry. Explicitly raising an `InternalServerError` causes a 500 to be returned.
      f882dca5
    • Rahul Kumar Saini's avatar
      feat(DC): Discover Dataset Config (#3596) · 4bf7a338
      Rahul Kumar Saini authored
      Discover dataset has a unique entity selection process
      
      This blocks conversion to config
      
      This logic shouldn't be generalized and should remain specific to discover, so I've moved it into the parser and freed up the dataset to be converted
      4bf7a338
    • Colton Allen's avatar
      feat(replays): Add error and session sample rate columns (#3588) · a8418756
      Colton Allen authored
      * Add error and session sample rate columns
      
      * Reverse column ordering
      a8418756
    • Enoch Tang's avatar
      ref(DC): Reformat how entities specify storages in configuration (#3591) · ffef0b44
      Enoch Tang authored
      ### Summary
      Currently, we are not able to move the `sessions` entity into configuration. This is because sessions contains different translation mappers for each of its selectable storages. This PR is responsible for reformatting how storages and translation mappers are defined in configuration. Entities now specify a `Sequence[EntityStorageConnection]`. In addition, a `SimpleQueryStorageSelector` was added to support this new format of storages in configuration.
      
      ### Before State
      Entity configuration:
      ```
      readable_storage: generic_metrics_distributions
      writable_storage: generic_metrics_distributions_raw
      translation_mappers: [x,y,z]
      ```
      * Storages were "implicitly" selected in code. For example, when there are two or more storages defined in an entity, only one single storage (usually the materialized_storage) is passed into the query plan builder.
      
      ### After State
      * Entity configuration:
      ```
      storages:
        - storage: generic_metrics_distributions
        translation_mappers: [x,y,z]
        - storage: generic_metrics_distributions_raw
        is_writable: true
        translation_mappers: [x,y,z]
      ```
      * All storages defined in configuration are passed into the query plan builder. It is the job of the query storage selector to determine which storage to use. As a result, all storages need to be selected explicitly in configuration. The addition of  `SimpleQueryStorageSelector` helps with that. 
      
      ### Blast Radius
      The configuration of all entities have been changed to use this format.
      
      ### Testing
      * Entity definitions and pluggable entity tests have been updated to use new format
      * A new `SimpleQueryStorageSelector` added.
      ffef0b44
  8. Jan 17, 2023
Loading