This project is mirrored from https://github.com/cockroachdb/cockroach.
Pull mirroring updated .
- Jan 11, 2024
-
-
Yahor Yuzefovich authored
release-23.1.14-rc: sql: skip tests under race that may trigger a fixed race in conn executor
-
Rebecca Taft authored
release-23.1.14-rc: sql: fix an exported gist out of bounds error (#117631) Co-Authored-By: Tommy Reilly <treilly@cockroachlabs.com>
-
- Jan 10, 2024
-
-
Tommy Reilly authored
Fixes: #111346 Release note: None Epic: None
-
- Jan 09, 2024
-
-
celiala authored
release-23.1.14-rc: changefeedccl: fix custom key column when used with CDC queries
-
- Jan 08, 2024
-
-
Yahor Yuzefovich authored
release-23.1.14-rc: sql/stats: deflake TestStatsAreDeletedForDroppedTables
-
Marylia Gutierrez authored
release-23.1.14-rc: server: fix total latency time on sql stats call
-
maryliag authored
For the top activity tables, we have a column `execution_total_cluster_seconds` with the total latency of all executions of that period. This value is important because the top activity table have up to 500 rows per aggregated timestamp, so if we add all latencies from it, we won't have the total, only the total of the top. We then have a column that has that total of that hour which is based on the main table. Previously, when making a request to the top activity table we were returning only of of those values as the total, which works as expected if your select is in a single aggregation period. The majority of requests won't be this way, so we need to add the values from all aggregated period selects. This commit update the query for the total select to get one value from each aggregated_ts and then adding those. Part Of CRDB-34884 Release note (bug fix): Fix value used for the total runtime on sql stats, which was using the wrong value previously, causing the UI to display values with more than 100%.
-
- Jan 04, 2024
-
-
rharding6373 authored
This PR skips TestTenantTempTableCleanup under race, since they can trigger a race in conn executor that has been mostly fixed. Epic: None Fixes: #117104 Release note: None
-
- Jan 02, 2024
-
-
Michael Erickson authored
release-23.1: sqlccl: increase statement timeout in TestShowCreateRedactableValues
-
Xin Hao Zhang authored
release-23.1: cluster-ui: allow multiple transaction details to show multiple apps
-
- Dec 28, 2023
-
-
Rafi Shamim authored
release-23.1: sql: add telemetry for mixed DDL/DML transactions
-
Michael Butler authored
release-23.1: roachtest: replace gs://cockroach-fixtures with gs://cockroach-fixtures-us-east1
-
- Dec 27, 2023
-
-
Michael Erickson authored
When running TestShowCreateRedactableValues under race, DDLs take longer to finish. Let's try increasing the statement timeout from 5s to 30s. Fixes: #116853 Epic: None Release note: None
-
- Dec 26, 2023
-
-
Yahor Yuzefovich authored
release-23.1: roachtest: retry copyfrom test on serializable error
-
- Dec 21, 2023
-
-
gs://cockroach-fixturesgs://cockroach-fixtures-us-east1Michael Butler authored
Informs #111371 Release note: none
-
Erik Grinaker authored
release-23.1: kvnemesis: properly encode range keys
-
- Dec 20, 2023
-
-
Rafi Shamim authored
release-23.1: cli/zip: show redacted CREATE TYPE statement in debug zip
-
Nick Travers authored
release-23.1: build: fix roachtest stress build; move scripts
-
- Dec 19, 2023
-
-
Austen authored
release-23.1: kvserver: skip repl queue rebalance under deadlock
-
Renato Costa authored
-
Rafi Shamim authored
release-23.1: sql: make txnCounter for BEGIN logs more understandable
-
Alex Barganier authored
release-23.1: pkg/util/aggmetric: tick histogram windows in AggHistogram
-
Alex Barganier authored
AggHistograms are wrappers around the histogram implementations found in pkg/util/metric. Internally, Histogram implementations within pkg/util/metric maintain histogram windows to calculate quantiles at each scrape by CockroachDB's TSDB, instead of storing every single histogram bucket. These windows are rotated periodically, where the current window becomes the previous window, and the current window is then set to a new histogram. This allows us to diff the two windows, and internally, pkg/util/metric has "ticking" functionality which is responsible for rotating these histogram windows. Unfortunately, since `pkg/util/metric/aggmetric` is in a separate package, somehow this "ticking"/rotating of histogram windows was never implemented into the AggHistogram. Because of this, it's likely that metrics powered by AggHistogram have been broken since its inception within CockroachDB's internal TSDB (but work fine in Prometheus). Previous patches did some work to expose this ticking library to AggHistogram, and this patch implements it. In this patch, we make it so AggHistogram ticks/rotates histogram windows, similar to how the other Histogram library does it. Since AggHistograms have child histograms, this means that the rotation of all histograms for both parent and children need to be done atomically. We implement this by providing the AggHistogram its own tick.Ticker, where the onTick function holds a RWMutex shared by the parent & all its children and rotates the histograms for all. With this in place, histogram windows are properly rotated for AggHistograms. Future work will merge `pkg/util/metric/aggmetric` into `pkg/util/metric`, after which we can once again make all this ticking functionality private to the metrics package. Release note (bug fix): Previously, all `AggHistogram`-powered metrics were not reporting quantiles properly in DB Console. The list of affected metrics is: - changefeed.message_size_hist - changefeed.parallel_io_queue_nanos - changefeed.sink_batch_hist_nanos - changefeed.flush_hist_nanos - changefeed.commit_latency - changefeed.admit_latency - jobs.row_level_ttl.span_total_duration - jobs.row_level_ttl.select_duration - jobs.row_level_ttl.delete_duration This patch fixes the histograms so that the quantiles in DB Console are reported correctly. Please note: these histograms were only broken in the DB Console metrics features, but were **not** broken in the Prometheus-compatible endpoint, `/_status/vars`.
-
Alex Barganier authored
Ticking functionality is generally something that we should consider internal to the histogram libraries. It's not ideal to expose any sort of tick functionality as part of the Histogram's public API. However, ticking functionality was never implemented in aggmetric.AggHistogram. In order to fix the bug, the AggHistogram needs to be able to tick the underlying histogram, as well as the underlying histogram for all its children, atomically. Unfortunately, since the aggmetrics exist in a separate package, there are only two ways to accomplish this: 1. Merge pkg/util/aggmetric into pkg/util/metric, so that package-private interfaces can be shared. 2. Pollute the public API of IHistogram with functions that enable external clients to force a tick of the histogram. [1] is the right approach, but is a heavyweight change that's not easily backportable. [2] is not ideal, but impacts a much smaller surface area, meaning it's easier to backport. Since the upcoming AggHistogram fix needs to be backported, this patch sets us up with [2]. We will backport a fix that impacts the minimum surface area, and a follow up patch will implement [1] on master so we have the desired approach long-term. metric.Histogram and metric.HdrHistogram are updated with implementations for the new interface functions, which simply invoke the equivalent functions on the underlying tick.Ticker. Release note: none
-
Alex Barganier authored
It's come to light that the `AggHistogram` from `pkg/util/metric/aggmetric` does not properly tick histogram windows. This needs to be fixed. We should make use of the tickHelper, but it's not exported from `pkg/util/metric`. This patch sets up future work to implement ticking by moving the tickHelper and associated "ticking" logic into its own package. This will make it easily shared between the metric and aggmetric packages. Exposing the ticker is not a desirable approach. Ideally, it should be internal to pkg/util/metric. Unfortunately, AggHistogram lives in a separate package and will require a ticker. The best approach here would be to merge pkg/util/aggmetric into pkg/util/metric, so we could keep the ticking stuff package-private while also giving AggHistogram access to it. However, these fixes need to be backportable, so we will do the thing that involves the minimum surface area first, and follow up with the merged package approach. Release note: none
-
Rafi Shamim authored
This patch adds feature counter telemetry for explicit transactions that have schema changes. We track is a transaction has DDL only or a mixture of DDL and DML, and if it succeeded or failed. Release note: None
-
Rafi Shamim authored
Previously, the txnCounter would not be incremented until after the transaction began. This made it hard to read the logs and understand which transaction a BEGIN statement was a part of. Now, the txnCounter is incremented just before the time of executing any statement in the NoTxn state - all implicit and explicit transactions must be started this way. Release note: None
-
Rafi Shamim authored
release-23.1: sql,opt: don't validate AOST during session migration
-
- Dec 18, 2023
-
-
Xin Hao Zhang authored
release-23.1: sql: add `StmtPosInTxn` to CommonSQLExecDetails
-
Rafi Shamim authored
When re-preparing a statement for a session migration, we want to skip evaluating and validating the AS OF SYSTEM TIME clause. During session migrations, we know that the statement will just be prepared, and not executed, and each statement could have different AOST timestamps. Therefore it is incorrect to evaluate the AOST clause and fix the transaction timestamp. No release note since this fixes a bug that only affects Serverless. Release note: None
-
Yahor Yuzefovich authored
-
Yahor Yuzefovich authored
release-23.1: sql/randgen: make insert values deterministic with a seed (#110399) Co-Authored-By: rharding6373 <rharding6373@users.noreply.github.com>
-
Yahor Yuzefovich authored
-
Yahor Yuzefovich authored
-
Renato Costa authored
Part of creating tenants involves learning about existing tenants in the system. Roachprod uses a query and invokes `cockroach sql --format json` to achieve that. However, we have seen this fail in the past because the output was not valid JSON. In this commit, we log the unexpected output in this case so that we can better understand what happened. Informs: #116681 Release note: None
-
Marylia Gutierrez authored
release-23.1: ui: remove "undefined" from events description
-
Yahor Yuzefovich authored
This builtin under the hood issues multiple TRUNCATE commands that can take non-trivial amount of time to execute. Release note: None
-
Rafi Shamim authored
release-23.1: testutils/docker: fix result parsing for single-node docker test
-
- Dec 17, 2023
-
-
Renato Costa authored
-
Renato Costa authored
-